feat(loki) : upgrade loki endpoint url #309
Conversation
|
@JGodin-C2C: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind deprecation |
|
@JGodin-C2C: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I don't get it, deprecation do seems to be a label, but does not seems to be working ? https://github.com/kubernetes/kubernetes/labels/kind%2Fdeprecation |
|
Here's the list of available labels for this repo https://github.com/falcosecurity/falcosidekick/labels?q=kind the link you gave is for kubernetes |
|
LGTM label has been added. Git tree hash: d7f99c05e62d5b8c8f505240e532565d5b17fd98
|
|
/kind cleanup |
|
Just a question, is this change breaking something? I tried yesterday with current Loki output and it still works with last release of Loki. |
|
@Issif I asked about there plan for this endpoint removal here : https://community.grafana.com/t/endpoint-deprecation/62271 J\x00 |
|
I changed the logic to variabilise in a config file the endpoint. |
poiana
added
dco-signoff: no
do-not-merge/contains-merge-commits
and removed
dco-signoff: yes
labels
|
@JGodin-C2C can you squash your commits please, I think it will think the DCO detection issue, thanks. I'll approve it right after |
what : According to the documentation : https://grafana.com/docs/loki/latest/api/#post-apiprompush /api/prom/push is deprecated and is replaced by /loki/api/v1/push why : standard api update We are allowing the configuration of the endpoint . This will NOT break alreadyu deployed lokisidekcick and is still futur proof Signed-off-by: Julien Godin <[email protected]>
|
LGTM label has been added. Git tree hash: 9d7b63bc2445fa269c5b35c44abf47b5a9719e54
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, JGodin-C2C The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind deprecation
Any specific area of the project related to this PR?
/area outputs
Why :
According to the documentation :
https://grafana.com/docs/loki/latest/api/#post-apiprompush
/api/prom/pushis deprecated and is replaced by/loki/api/v1/pushAny specific area of the project related to this PR? :
standard api upgrade
This change can break older unspecified loki versions
Signed-off-by: Julien Godin [email protected]