feat(loki): Add tenant for loki #308
Conversation
|
Welcome @JGodin-C2C! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
Thanks for your PR. Can you add this new setting in the config_example.yaml and README please |
README updated and example added as well. |
|
Hold on, i think i found a bug. Let me make a few test before. |
JGodin-C2C
force-pushed
the
master
branch
3 times, most recently
from
6a147c7
to
402f78e
Compare
|
@Issif Ok, i solved the problem i had , i updated the PR and fixed a bug. |
|
Can you also add it in env vars section please |
What : This change allows to add a "tenant header" in the configuration file at the loki.tenant key. Why : Loki is able to differentiate logs comming from a specific tenant , but it is needed to add a header in the configuration : https://grafana.com/docs/loki/latest/operations/multi-tenancy/ This change does not bring any breaking changes. Signed-off-by: Julien Godin <[email protected]>
Sure ! here you go. |
There was a problem hiding this comment.
Thank you.
I don't have a schedule for the release of 2.25, so I don't know when your change will be available for everybody. If you feel confident, you can still use the latest image, no breaking change have been added (we follow semver) and no major change either.
|
/approve |
|
LGTM label has been added. Git tree hash: 087aee85f06e0fb6a25badc9b4c667982afe9e2a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, JGodin-C2C The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
What this PR does / why we need it:
This change allows to add a "tenant header" in the configuration file at the
loki.tenant key.
Why :
Loki is able to differentiate logs coming from a specific tenant , but
it is needed to add a header in the configuration :
https://grafana.com/docs/loki/latest/operations/multi-tenancy/
This change does not bring any breaking changes.
Signed-off-by: Julien Godin [email protected]