Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version to falcosidekick #290

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 5, 2021

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

add version flag to falcosidekick, this will help to troubleshoot any possible community issues, because we can ask for the version that happened

$ docker run falcosecurity/falcosidekick:stable-amd64 --version
GitVersion:    2.24.0-17-g420e03e-dirty
GitCommit:     420e03e47c3b0e94bb901eafb5ee01786c8a537e
GitTreeState:  dirty
BuildDate:     '2021-12-05T14:58:21Z'
GoVersion:     go1.17.3
Compiler:      gc
Platform:      linux/amd64

it will log as well when falcosidekick starts

$ ./falcosidekick -c config.yaml
2021/12/05 16:06:55 [INFO]  : Falco Sidekick version: 2.24.0-11-gcefd9b8-dirty
2021/12/05 16:06:55 [INFO]  : Enabled Outputs : [Opsgenie]
2021/12/05 16:06:55 [INFO]  : Falco Sidekick is up and listening on :2801

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Carlos Panato <[email protected]>
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️ ❤️ ❤️

@poiana poiana added the lgtm label Dec 5, 2021
@poiana
Copy link

poiana commented Dec 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Dec 5, 2021

LGTM label has been added.

Git tree hash: 0958480e5c987522565b139c9c659b4e9c26e62d

@poiana poiana merged commit ac766b4 into falcosecurity:master Dec 5, 2021
@cpanato cpanato deleted the version branch December 6, 2021 08:08
@Issif Issif added this to the 2.25.0 milestone Mar 2, 2022
@Issif Issif mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants