-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KafkaRest as new output for Falco Sidekick #263
Conversation
Welcome @dirien! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
Thank you very much, this is a very valuable PR, with a really nice description. I'll review asap but a first look tells me it's already really good. 👍 |
@Issif, Thanks for the feedback. I changed everything according to your suggestions. looking forward. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 1 thing is missing, can you add your output in this list please
Signed-off-by: Engin Diri <[email protected]>
@Issif, done :) during the Yandex rebase it must slipped through 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats and thank you !!
LGTM label has been added. Git tree hash: c9f7536a6b043e7ccb6bc9a8b98d10a4f984ab63
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dirien, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Engin Diri [email protected]
What type of PR is this?
Fixes #262
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
The Kafka REST Proxy provides a RESTful interface to a Apache Kafka cluster, making it easy to produce and consume messages, view the state of the cluster, and perform administrative actions without using the native Kafka protocol or clients.
Which issue(s) this PR fixes: #262
Fixes #262
Special notes for your reviewer: