-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openfaas output type added #208
Conversation
@developer-guy: There is not a label identifying the kind of this PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @developer-guy! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
cc @Dentrax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks fora dding that, in general lgtm, but can you add the the new output in the readme and in the config_example as well?
Of course @cpanato, it is not completed yet, I'm going to complete it tonight 🙋🏻♂️ |
/hold |
@cpanato, the PR is ready to review now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the README too, please.
- Add
OpenFaas
in list of available outputs - Add settings in configuration
- in extract of
config_example.yaml
- in table of env vars
- in extract of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Batuhan Apaydın <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Thanks for this amazing work and all your patience with my huge amount of comments. Really good job, I'm glad you help us.
LGTM label has been added. Git tree hash: dfb4454e8bb03ce861f33e17bf881d8c56aeba4a
|
It was a honor for me, thank you, I'm really appreciate it🙏🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
nice work!! thanks so much for that!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
<Signed-off-by: Batuhan Apaydın [email protected]
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR adds OpenFaaS as an output module. So, we can start sending events to the OpenFaaS functions.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: