Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: add missing statds/dogstastd metrics #158

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 13, 2020

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:
webhook: add missing statds/dogstastd metrics

Which issue(s) this PR fixes:

Fixes partially #144

Special notes for your reviewer:

/assign @Issif

@poiana
Copy link

poiana commented Dec 13, 2020

@cpanato: The label(s) area/outputs cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:
webhook: add missing statds/dogstastd metrics

Which issue(s) this PR fixes:

Fixes partially #144

Special notes for your reviewer:

/assign @Issif

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested review from leodido and leogr December 13, 2020 14:42
@poiana poiana added the size/S label Dec 13, 2020
@Issif Issif added this to the 2.20.0 milestone Dec 13, 2020
@poiana poiana added the lgtm label Dec 17, 2020
@poiana
Copy link

poiana commented Dec 17, 2020

LGTM label has been added.

Git tree hash: e2a13d237ce59113e6ada141a653e98549f70bf7

@poiana
Copy link

poiana commented Dec 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b604df9 into falcosecurity:master Dec 17, 2020
@cpanato cpanato deleted the GH-144-webhook branch December 18, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants