Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.15 #128

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Conversation

KeisukeYamashita
Copy link
Contributor

Signed-off-by: KeisukeYamashita [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

Better to use the latest version of Go.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: KeisukeYamashita <[email protected]>
@poiana
Copy link

poiana commented Nov 24, 2020

@KeisukeYamashita: The label(s) area/build cannot be applied, because the repository doesn't have them

In response to this:

Signed-off-by: KeisukeYamashita [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

Better to use the latest version of Go.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- image: circleci/golang:1.14.12
- image: circleci/golang:1.15.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] You can find the list of images here → https://circleci.com/docs/2.0/circleci-images/#go-golang

@poiana
Copy link

poiana commented Nov 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 24, 2020

LGTM label has been added.

Git tree hash: 8a4a952fd10a7606ee138374d9c3a8e91e226f2c

@poiana poiana merged commit 6c5617f into falcosecurity:master Nov 24, 2020
@KeisukeYamashita KeisukeYamashita deleted the bump-golang branch November 24, 2020 16:05
Kaizhe pushed a commit to Kaizhe/falcosidekick that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants