-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudwatch Logs Output #127
Conversation
@cpanato: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks for your review @KeisukeYamashita
Thank you for updating 🙏 |
Some ideas: we can create the logstream if is not set. |
Ok, that's a good idea. If |
@Issif ok, give me a minute to refactor this code or do you prefer in a followup? |
Better to do all here, as it's a new Output |
ok, now if the LogStream is not set it try to create a stream and reuse that stream for the other calls
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about Stream creation
Signed-off-by: Carlos Panato <[email protected]>
LGTM label has been added. Git tree hash: 86d499622f9e0310e67ecec4a1dbd89f542652a0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Add Cloudwatch Logs Output
I still need to run some final manual tests to validate everything, but I would like to get some feedback if is missing something
Which issue(s) this PR fixes:
Fixes #46
Special notes for your reviewer: