Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Chat support #107

Merged
merged 7 commits into from
Nov 19, 2020
Merged

Add Google Chat support #107

merged 7 commits into from
Nov 19, 2020

Conversation

KeisukeYamashita
Copy link
Contributor

@KeisukeYamashita KeisukeYamashita commented Nov 18, 2020 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

Google Chat is a wonderful workspace app like Slack, Mattermost, etc.

image

Which issue(s) this PR fixes:

Fixes #102

Special notes for your reviewer:

The API description of the Google Chat API is described here https://developers.google.com/hangouts/chat/how-tos/webhooks.

@poiana
Copy link

poiana commented Nov 18, 2020

@KeisukeYamashita: The label(s) area/outputs cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

Google Chat is a wonderful workspace app like Slack, Mattermost, etc.

Which issue(s) this PR fixes:

Fixes #102

Special notes for your reviewer:

The API description of the is described here https://developers.google.com/hangouts/chat/how-tos/webhooks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested review from leodido and leogr November 18, 2020 16:06
@poiana
Copy link

poiana commented Nov 18, 2020

Welcome @KeisukeYamashita! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/L label Nov 18, 2020
@Issif
Copy link
Member

Issif commented Nov 18, 2020

Awesome, I'll review it asap. Thank you.

@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review November 18, 2020 16:15
@KeisukeYamashita KeisukeYamashita changed the title Add google chat support Add Google Chat support Nov 18, 2020
KeisukeYamashita
KeisukeYamashita commented Nov 18, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
Issif
Issif requested changes Nov 18, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
outputs/slack.go Outdated Show resolved Hide resolved
outputs/slack.go Outdated Show resolved Hide resolved
Issif
Issif previously approved these changes Nov 18, 2020
View reviewed changes
@poiana poiana added the lgtm label Nov 18, 2020
@poiana
Copy link

poiana commented Nov 18, 2020

LGTM label has been added.

Git tree hash: 29e528067b3c77fdabb87ae59268a4da9d91f6ba

@Issif
Copy link
Member

Issif commented Nov 18, 2020

@KeisukeYamashita just a little conflict to fix and it's all good 👍

@poiana
Copy link

poiana commented Nov 19, 2020

@KeisukeYamashita: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana removed the approved label Nov 19, 2020
KeisukeYamashita and others added 7 commits November 19, 2020 10:03
@KeisukeYamashita
Add Google chat support
88e9345 
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita
Fix unknown keyValue struct
52c7613 
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita
Preallocate widget var
97503c1 
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita
Fix typo in README
0b3127a 
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita
Add missing googleChat.messageformat
5d34b73 
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita @Issif
Update README.md
4c55f8d 
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita
Change googleChat to googlechat
a70cb77 
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita
Copy link
Contributor Author

Sorry, I accidentally merge the master branch... PTAL when you have time. Thank you in advance 🙇

@poiana poiana added the lgtm label Nov 19, 2020
@poiana
Copy link

poiana commented Nov 19, 2020

LGTM label has been added.

Git tree hash: de87a2dbe68cc3ca3e6f0d9954d683bcdbc2fe88

Issif
Issif previously approved these changes Nov 19, 2020
View reviewed changes
@leogr
Copy link
Member

leogr commented Nov 19, 2020

Hi @KeisukeYamashita

Thank you for your contribution 👍

Since we do not allow merge commits, could you please fix that by removing the Merge branch 'master' into add-google-chat-support commit and then perform a git rebase -i master?

We will be happy to merge this PR once that has been fixed 🚀

If you need any support on that, please let me know.

@KeisukeYamashita
Copy link
Contributor Author

@leogr Sorry, I removed the merge commit 🙇 Thank you for your kind notice and guide 🙇

image

leogr
leogr approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, LGTM now 👍

Thank you @KeisukeYamashita 👏

@poiana
Copy link

poiana commented Nov 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e932dda into falcosecurity:master Nov 19, 2020
@KeisukeYamashita KeisukeYamashita deleted the add-google-chat-support branch November 19, 2020 09:51
This was referenced Nov 19, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@Issif Issif Issif left review comments

@leodido leodido Awaiting requested review from leodido

Assignees

@leogr leogr

@Issif Issif

Labels
approved dco-signoff: yes kind/feature New feature or request lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Google Chat support
4 participants
@KeisukeYamashita @poiana @Issif @leogr