Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix falco dashboard variable #778

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Nov 11, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:
fix(falco/dashboard): make pod variable independent of triggered rules
CPU and memory are now visible for each pod, even when no rules have been triggered for
that falco instance.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

CPU and memory are now visible for each pod, even when no rules have been triggered for
that falco instance.

Signed-off-by: Aldo Lacuku <[email protected]>
@poiana poiana requested a review from bencer November 11, 2024 10:36
@poiana poiana requested a review from leogr November 11, 2024 10:36
@poiana poiana added the size/M label Nov 11, 2024
@alacuku alacuku changed the title ix falco dashboard variable fix falco dashboard variable Nov 11, 2024
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
@poiana
Copy link
Contributor

poiana commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 11, 2024

LGTM label has been added.

Git tree hash: e0f376af543e9c86580acb497daaeb652c5849bd

@poiana poiana merged commit 64cc795 into falcosecurity:master Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants