Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the key for the rulesfiles range #776

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Nov 8, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

attempt to fix an issue with a range to collect rules files content

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented Nov 8, 2024

@Issif: The label(s) area/falco-talon cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

attempt to fix an issue with a range to collect rules files content

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana added kind/bug Something isn't working dco-signoff: yes approved labels Nov 8, 2024
@poiana poiana requested review from bencer and leogr November 8, 2024 10:56
@poiana poiana added the size/XS label Nov 8, 2024
@poiana poiana added the lgtm label Nov 8, 2024
@poiana
Copy link
Contributor

poiana commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 8, 2024

LGTM label has been added.

Git tree hash: e8413bb5afc116bf2a81168e4dc3b42a158512fc

@poiana poiana merged commit ba7220b into master Nov 8, 2024
6 checks passed
@poiana poiana deleted the fix/range-rulesfiles branch November 8, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants