Drop circleci, add githb actions and refators #554
Conversation
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
poiana
added
kind/feature
|
as a follow up we can sign the chart with gpg, but will require someone to create the keys |
|
/assign @leogr @LucaGuerra also will need someone with admin access in circleci to remove the job from there |
|
looks like |
cpanato
force-pushed
the
add-gh-actions
branch
from
5c552b6
to
7c44bb4
Compare
Signed-off-by: cpanato <[email protected]>
cpanato
force-pushed
the
add-gh-actions
branch
from
7c44bb4
to
6d17c1d
Compare
Signed-off-by: cpanato <[email protected]>
cpanato
force-pushed
the
add-gh-actions
branch
from
77496ae
to
121a04e
Compare
|
also, the release might failed when we merge this because it see those charts as new charts. But after we merge this i will follow up to make sure everything will work i did some tests in a sample repo and that works, and got the same issues as here |
|
for the falco-exporter maybe we ignore that for now and i will test asap we merge this |
|
now it is fixed :) |
| branches: | ||
| - main | ||
| - master | ||
| paths: | ||
| - "charts/**" |
There was a problem hiding this comment.
A new chart will be released each time we push changes to charts. Right?
There was a problem hiding this comment.
yes, same behavior, just blocking when there is no changes in the chart, to we be able to update other things like ci and configs
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 10ddc154b31b8ddd96ea954c17e1db5fde288121
|
[PR 554 in the charts repo](falcosecurity/charts#554) refactored the folder structure of the Falco and Falcosidekick charts. This PR updates all the URLs with to the new structure. For example: from: https://github.com/falcosecurity/charts/tree/master/falco to: https://github.com/falcosecurity/charts/tree/master/charts/falco Signed-off-by: Pablo Musa <[email protected]>
[PR 554 in the charts repo](falcosecurity/charts#554) refactored the folder structure of the Falco and Falcosidekick charts. This PR updates all the URLs with to the new structure. For example: from: https://github.com/falcosecurity/charts/tree/master/falco to: https://github.com/falcosecurity/charts/tree/master/charts/falco Signed-off-by: Pablo Musa <[email protected]>
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
bonus point: it will push the oci chart to the github registry as well :)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist