This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Sourcery Starbot ⭐ refactored falcorocks/piprot #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
May 23, 2021
Comment on lines
-174
to
+178
| if version: | ||
| if verbose: | ||
| if verbose: | ||
| if version: | ||
| print('{} ({}) isn\'t available on PyPI ' | ||
| 'anymore!'.format(requirement, version)) | ||
| else: | ||
| if verbose: | ||
| else: |
There was a problem hiding this comment.
Function get_version_and_release_date refactored with the following changes:
- Hoist conditional out of nested conditional (
hoist-if-from-if) - Hoist repeated code outside conditional statement (
hoist-statement-from-if)
Comment on lines
-309
to
+308
| total_time_delta = total_time_delta + time_delta | ||
| total_time_delta += time_delta |
There was a problem hiding this comment.
Function main refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if) - Replace assignment with augmented assignment (
aug-assign)
Comment on lines
-436
to
-440
| if cli_args.quiet: | ||
| verbose = False | ||
| elif cli_args.verbatim: | ||
| if cli_args.quiet or cli_args.verbatim: | ||
| verbose = False | ||
|
|
There was a problem hiding this comment.
Function piprot refactored with the following changes:
- Merge duplicate blocks in conditional (
merge-duplicate-blocks) - Remove redundant conditional (
remove-redundant-if)
Comment on lines
-45
to
+49
| if response.status_code == 200: | ||
| api_response = json.loads(response.text) | ||
| return api_response['default_branch'] | ||
| else: | ||
| if response.status_code != 200: | ||
| return 'master' | ||
|
|
||
| api_response = json.loads(response.text) | ||
| return api_response['default_branch'] |
There was a problem hiding this comment.
Function get_default_branch refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: