fix(test_static.py): fix Windows CPython 3.13 build #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7621 7621
Branches 1244 1244
=========================================
Hits 7621 7621 ☔ View full report in Codecov by Sentry. |
vytas7
changed the title
vytas7
changed the title
|
Not sure why the change ls fixes it, but it looks fine |
CaselIT
approved these changes
Sep 28, 2024
Because we use a specialized I also extended the wheels test from just emulated to also build Windows, Mac and musllinux, so that we can easier catch these regressions later. |
|
Oh interesting. Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase now builds and passes tests on Windows and CPython 3.13: https://github.com/falconry/falcon/actions/runs/11082068662/job/30794594018.