fix(Cython): re-enable cythonization in Cython gates, do not enforce typing #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 5553 5553
Branches 880 880
=========================================
Hits 5553 5553 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
CaselIT
approved these changes
Oct 30, 2022
kgriffs
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typing issue in
FloatConverterthat is causing problems during runtime, and would be detected inmypytoo.This is fixed in my typing branch, but I just backported a simple switch not to enforce types in Cython since that has been observed to actually be a de-optimization in most cases.
The problem has been masked by another issue that our Cython gates have PEP 517 disabled in
tox, however, the Cython dependency is not installed into these.