-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(FAQ): add a FAQ entry based on @vytas7 discussion answer #1982
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6669 6669
Branches 1079 1079
=========================================
Hits 6669 6669 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together.
Apart from a couple of inline nitpicks, those code samples aren't particularly short. Maybe it would make sense to shorten the FAQ answer a lot, and link to a new recipe instead?
they are not, but I don't think we can shorten them more without making it difficult to follow. Maybe it makes sense to have this here now, then we refactor this to a recepie, that includes a better version for wsgi, this one for asgi, both with also sqlalchemy option and maybe redis? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple of minor tweaks, and this is now IMHO good enough to surface it in the docs.
We can always improve it later.
Once again, thanks for putting this together!
Thanks! |
#1981 (comment)
Summary of Changes
Add a faq item based on @vytas7 answer at #1981 (comment)