Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support notification after data consumption during Pipe() #38

Merged

Conversation

fako1024
Copy link
Owner

This adds race-free feedback about data being consumed from the initial source during a Pipe() operation (mostly to be used in E2E tests for els0r/goProbe#88). In addition it fixes a few race conditions with the plain afpacket source for completeness and extends testing.

Closes #37

@fako1024 fako1024 added the enhancement New feature or request label May 11, 2023
@fako1024 fako1024 added this to the Initial Release (v1) milestone May 11, 2023
@fako1024 fako1024 requested a review from els0r May 11, 2023 13:58
@fako1024 fako1024 self-assigned this May 11, 2023
@fako1024 fako1024 linked an issue May 11, 2023 that may be closed by this pull request
2 tasks
@fako1024
Copy link
Owner Author

@els0r In case you missed this one: I'll merge it so that I can finish up els0r/goProbe#118, again feel free to re-open / complain in case I missed something here...

@fako1024 fako1024 merged commit 58c6d54 into main May 12, 2023
@fako1024 fako1024 deleted the 37-support-feedback-once-all-mock-data-has-been-read-in-pipe branch May 12, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support feedback once all mock data has been read in Pipe()
1 participant