[bugfix] Fix incorrect handling of mock ring buffer wrap around #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scenario is covered
…buffer wraps around
fako1024
commented
May 1, 2023
fako1024
commented
May 1, 2023
fako1024
commented
May 1, 2023
fako1024
commented
May 1, 2023
els0r
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@els0r FYI, this should fix the issues mentioned here. Luckily it turned out not to be a fundamental race condition, just incorrect handling (and missing tests) for the mock ring buffer wrap-around. The memory barrier in place via the
TPacketstatus field seems to mimic the "real" kernel buffer sufficiently without additional synchronization.Closes #24