-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add hint that the generated data might be real ones #959
Conversation
Codecov Report
@@ Coverage Diff @@
## main #959 +/- ##
=======================================
Coverage 99.64% 99.65%
=======================================
Files 2146 2146
Lines 230380 230380
Branches 977 981 +4
=======================================
+ Hits 229563 229585 +22
+ Misses 796 774 -22
Partials 21 21
|
Random thought: why not for:
I'm not sure if this hint is helpful 🤔 |
We might want to add a general hint at some point (or maybe actually generate fake numbers). But I created this one to address an issue raised in Discord: |
IMO we should just add the hint now globally. For me it doesn't make really sense to add it here specifically just because one person asked in discord if values are real or not. |
I agree with @Shinigami92 that it should be done as a general hint and not for a specific function. The whole concept of faker is to generate data that looks real, so as he pointed out, they might be actually real! |
Yeah, I will think of a way to put it somewhere else. |
defba77
to
0773611
Compare
We should warn our users that the generated data may be working ones and not the well known
555
dummy ones.