Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#28): changed fakercloud url to cloudflare-ipfs.com #95

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

prisis
Copy link
Member

@prisis prisis commented Jan 11, 2022

…ar endpoint

@prisis
Copy link
Member Author

prisis commented Jan 11, 2022

many thanks to @bchavez hope its fine if we use the same url for faker

@prisis prisis changed the title fix(#28): changed faker cloud url to cloudflare-ipfs.com for the avat… fix(#28): changed fakercloud url to cloudflare-ipfs.com for the avat… Jan 11, 2022
lib/internet.js Outdated Show resolved Hide resolved
lib/internet.js Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 11, 2022
@Shinigami92
Copy link
Member

I will bump the prio due to the current code is not working anymore

@Shinigami92 Shinigami92 added p5-urgent 🔥 and removed p: 1-normal Nothing urgent labels Jan 11, 2022
@damienwebdev damienwebdev linked an issue Jan 11, 2022 that may be closed by this pull request
3 tasks
@bchavez
Copy link
Contributor

bchavez commented Jan 12, 2022

Hi @prisis, I'm sorry for the late reply; currently, my workload at my job is high and I don't get out until late. :(

Yes, of course, everyone is welcome to use the cloudflare-ipfs.com URL from Bogus -- source code is here: https://github.com/bchavez/Bogus/blob/321341a137a7f46e09bbabff78c3215f6c6c6ffa/Source/Bogus/DataSets/Internet.cs#L37-L38

Seems this PR will use the correct URL. 👍 As mentioned earlier, anyone is free to help host and seed the avatar images on IPFS. The details on how to help seed the files can be found here: bchavez/Bogus#336

With IPFS we can all help host static content in a decentralized way. The CloudFlare IPFS (public service) gateway takes care of bridging web2 clients (HTTP browsers) with the IPFS network. Also, we have pinned the Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye Content ID (CID) folder with pinning services like Pinata Cloud (https://www.pinata.cloud/) to also help seed/pin the files on IPFS so they don't go away. (creating 1GB account is free)

The more people that help seed Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye the more resilient the URLs become.

There is almost no hosting bandwidth required to seed & host because CloudFlare's IPFS gateway heavily caches the static content files coming in from "the HTTP internet". Only one content seed is needed in case a file drops out of cache from CloudFlare.

For reference, a primer on IPFS can be found here:

We have been using the cloudflare-ipfs.com URL for a long time and not a single problem :)

I hope this helps!
Brian Chavez

@prisis prisis changed the title fix(#28): changed fakercloud url to cloudflare-ipfs.com for the avat… fix(#28): changed fakercloud url to cloudflare-ipfs.com Jan 12, 2022
@prisis prisis merged commit 2fafe7b into faker-js:main Jan 12, 2022
@prisis prisis deleted the feature/avatar branch January 12, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove refs to old Marak repo
4 participants