chore: remove obsolete DefinitionTypes type #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: chore
Codecov Report
@@ Coverage Diff @@
## main #912 +/- ##
=======================================
Coverage 99.64% 99.65%
=======================================
Files 1958 1958
Lines 210679 210666 -13
Branches 907 907
=======================================
- Hits 209931 209930 -1
+ Misses 729 717 -12
Partials 19 19
|
pkuczynski
approved these changes
May 3, 2022
Shinigami92
requested changes
May 3, 2022
There was a problem hiding this comment.
I think you also need to refactor
faker/scripts/generateLocales.ts
Line 200 in 23ec9d1
I will fix that in a separate PR. |
Shinigami92
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed during my previous cleanup.