refactor(word): extract wordlist filter in separate method #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
ST-DDT
previously approved these changes
Apr 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #877 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 1958 1958
Lines 210862 210838 -24
Branches 919 904 -15
==========================================
- Hits 209649 209625 -24
Misses 1156 1156
Partials 57 57
|
ST-DDT
reviewed
Apr 26, 2022
ST-DDT
approved these changes
Apr 26, 2022
Shinigami92
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor shared logic in the word module in a separate function.
Designed in #589.