Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add definitions #84

Merged
merged 5 commits into from
Jan 11, 2022
Merged

feat: add definitions #84

merged 5 commits into from
Jan 11, 2022

Conversation

ericjeker
Copy link
Contributor

No description provided.

@Shinigami92 Shinigami92 self-requested a review January 11, 2022 11:12
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 11, 2022
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@Shinigami92
Copy link
Member

I will merge this now and potentially we could improve a bit in base branch
But this is really needed for many other modules

@damienwebdev Maybe you want to post review this one extra 🤔

@Shinigami92 Shinigami92 merged commit 90192db into faker-js:migrate-to-typescript Jan 11, 2022
This was referenced Jan 11, 2022
Shinigami92 added a commit that referenced this pull request Jan 11, 2022
Shinigami92 added a commit that referenced this pull request Jan 12, 2022
Shinigami92 added a commit that referenced this pull request Jan 12, 2022
Shinigami92 added a commit that referenced this pull request Jan 13, 2022
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
damienwebdev pushed a commit that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants