-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add definitions #84
Merged
Shinigami92
merged 5 commits into
faker-js:migrate-to-typescript
from
ericjeker:add-definitions
Jan 11, 2022
Merged
feat: add definitions #84
Shinigami92
merged 5 commits into
faker-js:migrate-to-typescript
from
ericjeker:add-definitions
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c627e6.
Shinigami92
reviewed
Jan 11, 2022
Shinigami92
approved these changes
Jan 11, 2022
I will merge this now and potentially we could improve a bit in base branch @damienwebdev Maybe you want to post review this one extra 🤔 |
Shinigami92
added a commit
that referenced
this pull request
Jan 11, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
added a commit
that referenced
this pull request
Jan 12, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
added a commit
that referenced
this pull request
Jan 12, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
added a commit
that referenced
this pull request
Jan 13, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Shinigami <[email protected]>
damienwebdev
pushed a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Shinigami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.