-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: immutable options in random.alpha methods #790
Conversation
Codecov Report
@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 99.35% 99.35% -0.01%
==========================================
Files 1921 1921
Lines 179109 179074 -35
Branches 897 902 +5
==========================================
- Hits 177961 177922 -39
- Misses 1092 1096 +4
Partials 56 56
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously there was no failing test, please add one to test that the options are not mutated
Similar to other methods I changed
random.alpha()
andrandom.alphaNumeric()
to don't alter their options.Hints for reviewers:
I can re-add the check, if you insist.