Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address zipCodeByState fix types #760

Merged
merged 2 commits into from
Apr 3, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 2, 2022

Fixes #759

For compatibility reasons, maybe I should revert the number type change until 6.2?

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 2, 2022
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Apr 2, 2022
@ST-DDT ST-DDT requested review from a team April 2, 2022 21:34
@ST-DDT ST-DDT self-assigned this Apr 2, 2022
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #760 (d6f9c48) into main (b40121e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d6f9c48 differs from pull request most recent head f459cf1. Consider uploading reports for the commit f459cf1 to get more accurate results

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1922     1918       -4     
  Lines      176505   176463      -42     
  Branches      909      909              
==========================================
- Hits       175352   175310      -42     
  Misses       1097     1097              
  Partials       56       56              
Impacted Files Coverage Δ
src/locales/ar/address/index.ts 100.00% <ø> (ø)
src/locales/en/address/index.ts 100.00% <ø> (ø)
src/locales/he/address/index.ts 100.00% <ø> (ø)
src/locales/ur/address/index.ts 100.00% <ø> (ø)
src/address.ts 99.09% <100.00%> (-0.01%) ⬇️
src/definitions/address.ts 100.00% <100.00%> (ø)
src/random.ts 99.46% <0.00%> (-0.01%) ⬇️
src/datatype.ts 100.00% <0.00%> (ø)

@ST-DDT ST-DDT enabled auto-merge (squash) April 3, 2022 13:59
@ST-DDT ST-DDT merged commit 214a77b into main Apr 3, 2022
@ST-DDT ST-DDT deleted the chore/address/zipCodeByState-fix-types branch April 3, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to handle the incompatible types in address.zipCodeByState()
3 participants