Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade min npm version from 7 to 6 #744

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

sergavshin
Copy link
Contributor

fixes #723

@sergavshin sergavshin requested a review from a team as a code owner April 1, 2022 05:41
@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent labels Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #744 (d44156a) into main (a55d617) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head d44156a differs from pull request most recent head 3808f0b. Consider uploading reports for the commit 3808f0b to get more accurate results

@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1925     1925           
  Lines      177002   177024   +22     
  Branches      909      909           
=======================================
+ Hits       175849   175871   +22     
  Misses       1097     1097           
  Partials       56       56           
Impacted Files Coverage Δ
src/address.ts 99.10% <0.00%> (-0.01%) ⬇️
src/commerce.ts 100.00% <0.00%> (ø)

@ST-DDT ST-DDT requested a review from a team April 1, 2022 08:54
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Apr 1, 2022

I'll leave this here so anybody can have this information.
Breaking changes v6 to v7:

  • automatically installing peer dependencies
  • npm uses the package.exports field making it no longer possible to require() npm’s internal modules
  • npx has been completely rewritten to use the npm exec command (prompt if module is not yet installed)
  • the output of npm audit has significantly changed both in the human-readable and --json output styles

source: github.blog

@ST-DDT ST-DDT enabled auto-merge (squash) April 1, 2022 17:01
@ST-DDT ST-DDT merged commit 0f517ea into faker-js:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is npm 7 required with node 14?
5 participants