-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: faker.finance.pin() #695
Conversation
Codecov Report
@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 1921 1921
Lines 176656 176673 +17
Branches 905 909 +4
=======================================
+ Hits 175503 175520 +17
Misses 1097 1097
Partials 56 56
|
What would be the expected behavior when a negative length is requested? |
I didn't consider that scenario. Do you think it should throw an error? |
I personally think it should throw when |
Co-authored-by: Piotr Kuczynski <[email protected]>
60b3f94
Co-authored-by: Piotr Kuczynski <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
fixes #472