Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced placeimg.com on loremflickr.com #692

Merged
merged 1 commit into from
Mar 27, 2022
Merged

fix: replaced placeimg.com on loremflickr.com #692

merged 1 commit into from
Mar 27, 2022

Conversation

JoCat
Copy link
Contributor

@JoCat JoCat commented Mar 27, 2022

Related to #556

After a little study of the topic, I went the easiest way and just replaced the links with placeimg.com on loremflickr.com
At least it will work a little more correctly as possible.

@JoCat JoCat requested a review from a team as a code owner March 27, 2022 03:31
@Shinigami92 Shinigami92 added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 27, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 27, 2022
@Shinigami92 Shinigami92 requested review from a team March 27, 2022 10:10
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #692 (b5ec88d) into main (877ac76) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176887   176887           
  Branches      897      897           
=======================================
  Hits       175732   175732           
  Misses       1099     1099           
  Partials       56       56           
Impacted Files Coverage Δ
src/image.ts 98.83% <100.00%> (ø)

@Shinigami92 Shinigami92 merged commit 2a49e82 into faker-js:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants