Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace substr with substring #678

Merged
merged 3 commits into from
Mar 26, 2022
Merged

chore: replace substr with substring #678

merged 3 commits into from
Mar 26, 2022

Conversation

Shinigami92
Copy link
Member

substr is deprecated

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 26, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 26, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 26, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 26, 2022 11:27
@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #678 (d328760) into main (81740ff) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176887   176887           
  Branches      897      897           
=======================================
  Hits       175732   175732           
  Misses       1099     1099           
  Partials       56       56
Impacted Files Coverage Δ
src/fake.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 requested a review from a team March 26, 2022 11:33
@ST-DDT ST-DDT enabled auto-merge (squash) March 26, 2022 18:17
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 26, 2022 18:18
@Shinigami92 Shinigami92 changed the title chore: replace substr with substring chore: replace substr with substring test Mar 26, 2022
@Shinigami92 Shinigami92 changed the title chore: replace substr with substring test chore: replace substr with substring Mar 26, 2022
@Shinigami92 Shinigami92 merged commit 877ac76 into main Mar 26, 2022
@Shinigami92 Shinigami92 deleted the chore-replace-substr-with-substring branch March 26, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
5 participants
@Shinigami92 @pkuczynski @ST-DDT @import-brain @xDivisionByZerox