Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use number tuple as input for coordinate #668

Merged
merged 4 commits into from
Mar 25, 2022
Merged

refactor: use number tuple as input for coordinate #668

merged 4 commits into from
Mar 25, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Mar 24, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 24, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 24, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 24, 2022 11:57
@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #668 (d549ce8) into main (a299c22) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176859   176882   +23     
  Branches      895      897    +2     
=======================================
+ Hits       175700   175727   +27     
+ Misses       1103     1099    -4     
  Partials       56       56
Impacted Files Coverage Δ
src/address.ts 99.10% <100.00%> (+0.41%) ⬆️
src/vendor/unique.ts 95.16% <0.00%> (+1.61%) ⬆️

ST-DDT
ST-DDT requested changes Mar 24, 2022
View reviewed changes
src/address.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 requested review from ST-DDT and a team March 24, 2022 12:23
@ST-DDT ST-DDT requested a review from a team March 24, 2022 12:27
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 24, 2022
@ST-DDT ST-DDT requested a review from a team March 25, 2022 13:00
@Shinigami92 Shinigami92 merged commit 11ebb0b into main Mar 25, 2022
@Shinigami92 Shinigami92 deleted the refactor-tuple-coordinate branch March 25, 2022 18:25
@xDivisionByZerox xDivisionByZerox mentioned this pull request Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @import-brain