Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky unique test coverage #667

Merged
merged 2 commits into from
Mar 25, 2022
Merged

test: fix flaky unique test coverage #667

merged 2 commits into from
Mar 25, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 24, 2022

No more
grafik

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Mar 24, 2022
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Mar 24, 2022
@ST-DDT ST-DDT self-assigned this Mar 24, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner March 24, 2022 11:48
Shinigami92
Shinigami92 previously approved these changes Mar 24, 2022
@Shinigami92 Shinigami92 requested a review from a team March 24, 2022 11:52
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #667 (e8fc3c6) into main (9291b62) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176882   176882           
  Branches      895      897    +2     
=======================================
+ Hits       175725   175727    +2     
+ Misses       1101     1099    -2     
  Partials       56       56           
Impacted Files Coverage Δ
src/vendor/unique.ts 95.16% <0.00%> (+1.61%) ⬆️

@import-brain import-brain added the s: accepted Accepted feature / Confirmed bug label Mar 24, 2022
@ST-DDT ST-DDT requested a review from a team March 25, 2022 12:57
@Shinigami92 Shinigami92 requested a review from a team March 25, 2022 18:41
@ST-DDT ST-DDT merged commit e62fd15 into main Mar 25, 2022
@ST-DDT ST-DDT deleted the fix/unique-coverage branch March 25, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants