Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: extract defaults from the comments if absent otherwise #657

Merged
merged 2 commits into from
Mar 23, 2022
Merged

docs: extract defaults from the comments if absent otherwise #657

merged 2 commits into from
Mar 23, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 22, 2022

Old

grafik

New

grafik

Diff

grafik

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Mar 22, 2022
@ST-DDT ST-DDT self-assigned this Mar 22, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner March 22, 2022 18:39
@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #657 (fd44b38) into main (3f3de78) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head fd44b38 differs from pull request most recent head 5c7beab. Consider uploading reports for the commit 5c7beab to get more accurate results

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files        1923     1923           
  Lines      176857   176853    -4     
  Branches      906      908    +2     
=======================================
- Hits       175685   175683    -2     
+ Misses       1116     1114    -2     
  Partials       56       56
Impacted Files Coverage Δ
src/iban.ts 100.00% <0.00%> (ø)
src/vendor/unique.ts 95.16% <0.00%> (+1.61%) ⬆️

@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Mar 22, 2022
@Shinigami92 Shinigami92 requested a review from a team March 22, 2022 18:54
@prisis prisis enabled auto-merge (squash) March 23, 2022 11:50
@prisis prisis merged commit e643835 into main Mar 23, 2022
@Shinigami92 Shinigami92 deleted the docs/comment-defaults branch March 23, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@prisis prisis prisis approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @prisis @Shinigami92