Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: renovate ru locales #639

Merged
merged 9 commits into from
Apr 7, 2022
Merged

chore: renovate ru locales #639

merged 9 commits into from
Apr 7, 2022

Conversation

serembon
Copy link
Contributor

@serembon serembon commented Mar 20, 2022 •
edited
Loading

Updated:

  1. Companies prefixes and suffixes
  2. Female fist and middle names
  3. Male fist and middle names

@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Mar 20, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Mar 20, 2022
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022 •
edited
Loading

Codecov Report

Merging #639 (910ebf5) into main (d54d2ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main     #639    +/-   ##
========================================
  Coverage   99.34%   99.34%            
========================================
  Files        1921     1921            
  Lines      176693   177120   +427     
  Branches      909      909            
========================================
+ Hits       175540   175967   +427     
  Misses       1097     1097            
  Partials       56       56
Impacted Files Coverage Δ
src/locales/ru/company/prefix.ts 100.00% <100.00%> (ø)
src/locales/ru/company/suffix.ts 100.00% <100.00%> (ø)
src/locales/ru/name/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/ru/name/female_middle_name.ts 100.00% <100.00%> (ø)
src/locales/ru/name/male_first_name.ts 100.00% <100.00%> (ø)
src/locales/ru/name/male_middle_name.ts 100.00% <100.00%> (ø)

@Shinigami92
Copy link
Member

I assume this PR is finished, so I pull it out of draft state

@Shinigami92 Shinigami92 marked this pull request as ready for review April 5, 2022 15:58
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 5, 2022 15:58
Shinigami92
Shinigami92 previously approved these changes Apr 5, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from a team April 5, 2022 15:58
@serembon serembon changed the title chore(ru-locale): renovate male/female names, add suffix/prefix/companies names chore(ru-locale): renovate male/female names, add new companies suffix/prefix names Apr 6, 2022
Shinigami92
Shinigami92 previously approved these changes Apr 6, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from ST-DDT April 6, 2022 17:35
@ST-DDT ST-DDT requested review from a team and Shinigami92 April 6, 2022 18:49
@Shinigami92 Shinigami92 changed the title chore(ru-locale): renovate male/female names, add new companies suffix/prefix names chore: renovate ru locales Apr 7, 2022
@Shinigami92 Shinigami92 merged commit 81171c9 into faker-js:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@serembon serembon

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
3 participants
@serembon @Shinigami92 @ST-DDT