Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve random jsdocs (part 2) #562

Merged
merged 4 commits into from
Mar 1, 2022
Merged

docs: improve random jsdocs (part 2) #562

merged 4 commits into from
Mar 1, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 25, 2022

Ref: #203

@ST-DDT ST-DDT added the c: docs Improvements or additions to documentation label Feb 25, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner February 25, 2022 17:30
@ST-DDT ST-DDT self-assigned this Feb 25, 2022
This was referenced Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #562 (9e108d8) into main (61fafe4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1920     1920           
  Lines      176374   176414   +40     
  Branches      904      904           
=======================================
+ Hits       175217   175257   +40     
  Misses       1101     1101           
  Partials       56       56           
Impacted Files Coverage Δ
src/random.ts 99.39% <100.00%> (+0.05%) ⬆️

pkuczynski
pkuczynski previously approved these changes Feb 25, 2022
@pkuczynski
Copy link
Member

Sorry I didnt find time this week to work on this @ST-DDT :(

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 25, 2022

@pkuczynski No problem.

@prisis prisis requested a review from Shinigami92 March 1, 2022 17:36
@Shinigami92 Shinigami92 merged commit 6a2b198 into main Mar 1, 2022
@Shinigami92 Shinigami92 deleted the jsdocs/random-2 branch March 1, 2022 19:13
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants