Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover source instead of bundled code #432

Merged
merged 5 commits into from
Feb 6, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 self-assigned this Feb 5, 2022
@Shinigami92 Shinigami92 linked an issue Feb 5, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #432 (a7fdb02) into main (ff54abb) will increase coverage by 5.06%.
The diff coverage is 95.65%.

❗ Current head a7fdb02 differs from pull request most recent head 71360c9. Consider uploading reports for the commit 71360c9 to get more accurate results

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   94.24%   99.30%   +5.06%     
==========================================
  Files        1920     1920              
  Lines      173955   173957       +2     
  Branches      108      895     +787     
==========================================
+ Hits       163942   172747    +8805     
+ Misses       9905     1118    -8787     
+ Partials      108       92      -16     
Impacted Files Coverage Δ
src/helpers.ts 98.77% <0.00%> (+98.77%) ⬆️
src/address.ts 98.13% <100.00%> (+98.13%) ⬆️
src/finance.ts 98.53% <100.00%> (+98.53%) ⬆️
src/image.ts 98.56% <100.00%> (+98.56%) ⬆️
src/image_providers/lorempicsum.ts 95.27% <100.00%> (+95.27%) ⬆️
src/image_providers/lorempixel.ts 92.90% <100.00%> (+92.90%) ⬆️
src/image_providers/unsplash.ts 99.37% <100.00%> (+99.37%) ⬆️
src/internet.ts 99.04% <100.00%> (+99.04%) ⬆️
src/name.ts 94.02% <100.00%> (+94.02%) ⬆️
src/unique.ts 100.00% <100.00%> (+100.00%) ⬆️
... and 52 more

@Shinigami92
Copy link
Member Author

Please note that I explicitly left test/locale-imports.spec.ts as is, so we currently still need to build the code before running the tests

@Shinigami92
Copy link
Member Author

Currently trying to find a way to prevent the replacement of ||= just to support Node 14.
The bundled code should already cover that.

@Shinigami92
Copy link
Member Author

For now we rewrote it, we can find a way later in another PR if needed

@Shinigami92 Shinigami92 marked this pull request as ready for review February 5, 2022 12:03
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 5, 2022 12:03
ST-DDT
ST-DDT previously approved these changes Feb 5, 2022
@ST-DDT ST-DDT requested a review from a team February 5, 2022 17:13
@ST-DDT ST-DDT merged commit e618a4b into main Feb 6, 2022
@ST-DDT ST-DDT deleted the test-cover-src-instead-of-dist branch February 6, 2022 10:14
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover source instead of bundled code
3 participants