Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rewrite music tests #383

Merged
merged 7 commits into from
Feb 1, 2022
Merged

test: rewrite music tests #383

merged 7 commits into from
Feb 1, 2022

Conversation

piotrekn
Copy link
Contributor

No description provided.

@piotrekn piotrekn requested a review from a team as a code owner January 31, 2022 22:12
@ST-DDT ST-DDT mentioned this pull request Jan 31, 2022
Closed
@ST-DDT ST-DDT added the c: test label Jan 31, 2022
ST-DDT
ST-DDT requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, expect one small detail.

test/music.spec.ts Outdated Show resolved Hide resolved
@piotrekn piotrekn requested a review from ST-DDT January 31, 2022 22:57
ST-DDT
ST-DDT previously approved these changes Jan 31, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team January 31, 2022 23:36
import-brain
import-brain previously approved these changes Feb 1, 2022
View reviewed changes
Shinigami92
Shinigami92 requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a NON_SEEDED_BASED_RUN = 5 like in the other new tests, so we can ensure stability

@piotrekn piotrekn dismissed stale reviews from import-brain and ST-DDT via ba87fb7 February 1, 2022 08:04
ST-DDT
ST-DDT previously approved these changes Feb 1, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 1, 2022 09:53
@Shinigami92 Shinigami92 merged commit b9c9f14 into faker-js:main Feb 1, 2022
@piotrekn piotrekn deleted the test--rewrite-music-tests branch February 12, 2022 23:21
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@piotrekn @bmenant
test: rewrite music tests (faker-js#383)
e974dd3
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@piotrekn @demipel8
test: rewrite music tests (faker-js#383)
4aed131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain left review comments

Assignees

@piotrekn piotrekn

Labels
c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
4 participants
@piotrekn @ST-DDT @Shinigami92 @import-brain