-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more arabic names dataset #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting looks good. I cannot verify the actual translations though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we can't validate the translations except for using Google Translate.
@JessicaSachs Was it expected to merge something into main that was targeted for v6.2? |
@@ -0,0 +1,13 @@ | |||
export default [ | |||
'فاطمه', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the other files are not formatted at all and now causing CI errors. We need 3 maintainers to fix the main branch. 1 that creates the PR and two approvals.
Until then we cannot rebase any of the other PRs anymore 😬
This reverts commit 86f1208.
@Shinigami92 This could be considered a stability change, the reason I add these files is when I used AR locale the findName Method returns an English first name with an Arabic last name, I tried to debug the actual issue but I couldn't figure it out but adding these files returns a valid Arabic name |
I know, sorry if we did not clarify that to much right now, but we maintainers are currently working daily multiple hours on rewriting e.g. the whole test suite and introduce linting and such. Internally we plan what we are currently focus on, and more and more code on top of what we currently need to fix and stabilize is currently not helping. Sorry, I already work like 10h per day currently on the Code base. I can really do not more right now to speedup the process. |
@wael-fadlallah Could you please create a new PR with your changes? |
@ST-DDT No need for apologies I'm happy to help, just to make sure everything will go smoothly this time can I know what is the formatting issue that caused troubles in my first PR |
Yeah for sure, it was wrongly indented lines and the trailing You don't need to care for these yourself, just run You can also see now lint errors in the files changes tab: https://github.com/faker-js/faker/pull/362/files |
Co-authored-by: in-ceptive <[email protected]>
Co-authored-by: in-ceptive <[email protected]>
Co-authored-by: in-ceptive <[email protected]>
No description provided.