Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use recommended no-var-requires #360

Merged
merged 3 commits into from
Jan 30, 2022
Merged

chore: use recommended no-var-requires #360

merged 3 commits into from
Jan 30, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 29, 2022
@Shinigami92 Shinigami92 added this to the v6.0 - Project stability milestone Jan 29, 2022
@Shinigami92 Shinigami92 self-assigned this Jan 29, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 29, 2022 18:46
ST-DDT
ST-DDT approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to turn this rule off for tests only?

@ST-DDT ST-DDT requested a review from a team January 29, 2022 18:52
@Shinigami92
Copy link
Member Author

Is it possible to turn this rule off for tests only?

Yes, should I?

@Shinigami92 Shinigami92 merged commit c1ae64c into main Jan 30, 2022
@Shinigami92 Shinigami92 deleted the no-var-requires branch January 30, 2022 10:25
@Shinigami92
Copy link
Member Author

I discussed with @ST-DDT that we don't want to implicitly allow it for tests, we can explicitly use the comments

bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @bmenant
chore: use recommended no-var-requires (faker-js#360)
5510fee
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
chore: use recommended no-var-requires (faker-js#360)
f183d47
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
chore: use recommended no-var-requires (faker-js#360)
137f489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @prisis