Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add required twitter meta tags #3232

Merged
merged 3 commits into from
Nov 3, 2024
Merged

docs: add required twitter meta tags #3232

merged 3 commits into from
Nov 3, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 28, 2024

This PR adds the required metadata tags for twitter to show a bi preview.

New Tags:

  • og:title
  • twitter:title
  • twitter:site
  • twitter:image:alt

I went for these tags because GitHub and Gitlab and other pages use them as well.

Before

before-only-link
Link: https://fakerjs.dev/about/announcements/2024-10-26.html

After

after-image-included
Link: https://fakerjs-st-ddt.netlify.app/about/announcements/2024-10-26.html

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 28, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 28, 2024
@ST-DDT ST-DDT requested a review from a team October 28, 2024 19:16
@ST-DDT ST-DDT self-assigned this Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9b8485d
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67272d21f30e330008c355c0
😎 Deploy Preview https://deploy-preview-3232.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT marked this pull request as ready for review October 28, 2024 19:23
@ST-DDT ST-DDT requested review from a team October 28, 2024 19:23
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (290e7c9) to head (9b8485d).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3232   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2805     2805           
  Lines      217098   217098           
  Branches      968      970    +2     
=======================================
  Hits       217018   217018           
  Misses         80       80           

see 1 file with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) November 3, 2024 07:58
@ST-DDT ST-DDT merged commit cb97682 into next Nov 3, 2024
23 checks passed
@ST-DDT ST-DDT deleted the docs/metatags/twitter branch November 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants