-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(string): improve documentation for length parameters #3216
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3216 +/- ##
==========================================
+ Coverage 99.94% 99.96% +0.01%
==========================================
Files 2805 2805
Lines 217098 217098
Branches 962 972 +10
==========================================
+ Hits 216989 217021 +32
+ Misses 109 77 -32
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is great for documentation purposes, I don't see how this fixes #2695 fully.
It isnt meant to. |
I was nearly certain about this, but the current PR description said otherwise:
|
The PR fixes the referenced comment, not the entire issue. I'll change the description to make it more obvious. |
Merging earlier to include in release |
Fixes #2695 (comment)
The rest of the issue will be fixed in a separate PR.
Improves and unifies the documentation of the length parameter in the string module.