Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(system): remove obsolete SK common file name test #3206

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 20, 2024

Fixes #1885


SK doesn't have any mime type files, so there is no reason to have a dedicated test for the SK locale.
This PR removes the obsolete test.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Oct 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 20, 2024
@ST-DDT ST-DDT requested review from a team October 20, 2024 19:52
@ST-DDT ST-DDT self-assigned this Oct 20, 2024
Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f016ae1
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67155f98dc4c840008b96d54
😎 Deploy Preview https://deploy-preview-3206.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (3f3d628) to head (f016ae1).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3206      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2798     2798              
  Lines      227335   227335              
  Branches      957      958       +1     
==========================================
- Hits       227262   227260       -2     
- Misses         73       75       +2     

see 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox merged commit b8e94a5 into next Oct 21, 2024
27 checks passed
@xDivisionByZerox xDivisionByZerox deleted the test/system/common-file-name/sk branch October 21, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check whether the system commonFileName (SK) test is still useful
4 participants