Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): trim excessive Croatian last names #3204

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 20, 2024

Fixes #1802


This PR reduces the Croatian last names from 11k -> 1k.

The last names have been selected using:

import { faker, hr } from '@faker-js/faker';

console.log(
  JSON.stringify(
    faker.helpers.arrayElements(hr.person.last_name.generic, 1000).sort()
  )
);

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Oct 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 20, 2024
@ST-DDT ST-DDT requested review from a team October 20, 2024 18:34
@ST-DDT ST-DDT self-assigned this Oct 20, 2024
Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ec0c484
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6716288eef076f0008c270f5
😎 Deploy Preview https://deploy-preview-3204.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (b8e94a5) to head (ec0c484).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3204      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2798     2798              
  Lines      227335   216718   -10617     
  Branches      960      955       -5     
==========================================
- Hits       227269   216641   -10628     
- Misses         66       77      +11     
Files with missing lines Coverage Δ
src/locales/hr/person/last_name.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) October 21, 2024 10:10
@xDivisionByZerox xDivisionByZerox merged commit 18e59aa into next Oct 21, 2024
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the locale/trim/hr/person/last-name branch October 21, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hr locale has excessive number of lastNames
4 participants