Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animal): add petName method #3196

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

suyashgulati
Copy link
Contributor

To resolve #2206

Adds new method petName on animal module

@suyashgulati suyashgulati requested a review from a team as a code owner October 19, 2024 10:20
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit b319411
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6720d251ff484c000804fc0e
😎 Deploy Preview https://deploy-preview-3196.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@suyashgulati
Copy link
Contributor Author

suyashgulati commented Oct 19, 2024

Need maintainers' help on resolving the test failure:

Error: The locale data for 'animal.petName' are missing in this locale.
  Please contribute the missing data to the project or use a locale/Faker instance that has these data.
  For more information see https://fakerjs.dev/guide/localization.html

I am not sure what needs to be done for this. Do I need to add any other locale than en to resolve this?

Copy link
Contributor

GitHub Actions has found some problems running the preflight checks.

Please make sure to:

  • run pnpm run preflight locally
  • fix all issues until the command completes without errors
  • commit and push the changes

src/modules/animal/index.ts Outdated Show resolved Hide resolved
test/modules/animal.spec.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 19, 2024
@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent m: animal Something is referring to the animal module labels Oct 19, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Oct 19, 2024

@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts and removed s: on hold Blocked by something or frozen to avoid conflicts labels Oct 19, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Oct 26, 2024

This is no longer blocked, but you have to adjust the test file.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (081a795) to head (b319411).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3196   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2804     2805    +1     
  Lines      216974   217025   +51     
  Branches      961      966    +5     
=======================================
+ Hits       216902   216954   +52     
+ Misses         72       71    -1     
Files with missing lines Coverage Δ
src/definitions/animal.ts 100.00% <ø> (ø)
src/locales/en/animal/index.ts 100.00% <100.00%> (ø)
src/locales/en/animal/pet_name.ts 100.00% <100.00%> (ø)
src/modules/animal/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

test/modules/animal.spec.ts Outdated Show resolved Hide resolved
src/locales/en/animal/pet_name.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from matthewmayer and a team October 29, 2024 12:17
@ST-DDT ST-DDT merged commit c02beea into faker-js:next Oct 29, 2024
23 checks passed
@ST-DDT
Copy link
Member

ST-DDT commented Oct 29, 2024

Thanks for your contribution. ❤️
Your additions will be available in Faker v9.2.0.
While I don't have an exact release date for it yet, we will likely release it somewhat soonish (a week - a few weeks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: animal Something is referring to the animal module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pet names
4 participants