Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: remove preflight failure comment #3188

Merged
merged 15 commits into from
Nov 9, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 16, 2024

This PR removes the preflight failure comment.

The github CI failure in combination with the error annotations are sufficient to guide the users.

  • git diff --cached --name-only | sed -E 's/^(.*)$/::error file=\1,title=Diff detected::Please run `pnpm run preflight` and commit the changes./'

@ST-DDT ST-DDT added p: 2-high Fix main branch c: infra Changes to our infrastructure or project setup labels Oct 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 16, 2024
@ST-DDT ST-DDT requested review from a team October 16, 2024 18:49
@ST-DDT ST-DDT self-assigned this Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit c4afe2b
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672f34182ffc7300087ca5e2
😎 Deploy Preview https://deploy-preview-3188.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (525fedc) to head (c4afe2b).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3188      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      217115   217115              
  Branches      972      586     -386     
==========================================
- Hits       217030   217026       -4     
- Misses         85       89       +4     

see 2 files with indirect coverage changes

Shinigami92
Shinigami92 previously approved these changes Oct 17, 2024
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 17, 2024 16:12
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 26, 2024

Team Decision

  • We will remove the comment, the error annotations are sufficient

@ST-DDT ST-DDT marked this pull request as draft October 26, 2024 14:21
@ST-DDT ST-DDT marked this pull request as ready for review October 26, 2024 16:52
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 26, 2024

Ready for review

@ST-DDT ST-DDT changed the title infra: inline preflight script infra: remove preflight failure comment Oct 26, 2024
@ST-DDT ST-DDT merged commit 519d212 into next Nov 9, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infra/preflight/inline-script branch November 9, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 2-high Fix main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants