-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: remove preflight failure comment #3188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 2-high
Fix main branch
c: infra
Changes to our infrastructure or project setup
labels
Oct 16, 2024
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shinigami92
reviewed
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3188 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2805 2805
Lines 217115 217115
Branches 972 586 -386
==========================================
- Hits 217030 217026 -4
- Misses 85 89 +4 |
Shinigami92
previously approved these changes
Oct 17, 2024
Team Decision
|
Ready for review |
ST-DDT
changed the title
infra: inline preflight script
infra: remove preflight failure comment
Oct 26, 2024
xDivisionByZerox
previously approved these changes
Nov 2, 2024
xDivisionByZerox
previously approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the preflight failure comment.
The github CI failure in combination with the error annotations are sufficient to guide the users.
faker/.github/workflows/pr.yml
Line 50 in ee45594