Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: iban might be invalid due to country specific rules #3175

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 12, 2024

Addresses #1832

This PR adds a more specific warning to the IBAN method to make it more obvious that it randomly generates the IBAN without taking country specific rules into account.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Oct 12, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 12, 2024
@ST-DDT ST-DDT requested review from a team October 12, 2024 09:23
@ST-DDT ST-DDT self-assigned this Oct 12, 2024
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4c9311d
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67100b960a30d10008a9f708
😎 Deploy Preview https://deploy-preview-3175.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (df59724) to head (4c9311d).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3175      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2798     2798              
  Lines      227367   227367              
  Branches      578      576       -2     
==========================================
- Hits       227292   227280      -12     
- Misses         75       87      +12     
Files with missing lines Coverage Δ
src/modules/finance/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT linked an issue Oct 12, 2024 that may be closed by this pull request
10 tasks
@ST-DDT ST-DDT requested review from a team October 13, 2024 14:22
@ST-DDT ST-DDT enabled auto-merge (squash) October 16, 2024 18:53
@ST-DDT ST-DDT merged commit 6a9ca8a into next Oct 16, 2024
21 checks passed
@ST-DDT ST-DDT deleted the docs/finance/iban-validation branch October 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finance.iban does not create valid iban
3 participants