Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commerce): more varied product descriptions #3174

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

matthewmayer
Copy link
Contributor

fix #2871

samples:

Sleek Chips designed with Concrete for substantial performance
Kuhn and Sons's most advanced Soap technology increases better capabilities
New magenta Hat with ergonomic design for worthwhile comfort
Ergonomic Car made with Granite for all-day somber support
New Chicken model with 28 GB RAM, 969 GB storage, and winding features
Stylish Table designed to make you stand out with dark looks
The Enterprise-wide dedicated groupware Chips offers reliable performance and empty design
Professional-grade Pizza perfect for same training and recreational use
The Jessika Ball is the latest in a series of bleak products from Hickle, Langworth and Jaskolski
Innovative Chips featuring authentic technology and Rubber construction
Discover the young new Shoes with an exciting mix of Fresh ingredients
The sleek and gigantic Pizza comes with purple LED lighting for smart functionality
Introducing the Japan-inspired Mouse, blending better style with local craftsmanship
Our fish-friendly Tuna ensures meager comfort for your pets
Experience the plum brilliance of our Chair, perfect for shoddy environments
Savor the fluffy essence in our Cheese, designed for mediocre culinary adventures
Featuring Vanadium-enhanced technology, our Shoes offers unparalleled muted performance
The tan Keyboard combines Gibraltar aesthetics with Argon-based durability
Our delicious-inspired Computer brings a taste of luxury to your all lifestyle
Discover the lion-like agility of our Keyboard, perfect for valuable users

fix faker-js#2871

samples:
```
Sleek Chips designed with Concrete for substantial performance
Kuhn and Sons's most advanced Soap technology increases better capabilities
New magenta Hat with ergonomic design for worthwhile comfort
Ergonomic Car made with Granite for all-day somber support
New Chicken model with 28 GB RAM, 969 GB storage, and winding features
Stylish Table designed to make you stand out with dark looks
The Enterprise-wide dedicated groupware Chips offers reliable performance and empty design
Professional-grade Pizza perfect for same training and recreational use
The Jessika Ball is the latest in a series of bleak products from Hickle, Langworth and Jaskolski
Innovative Chips featuring authentic technology and Rubber construction
Discover the young new Shoes with an exciting mix of Fresh ingredients
The sleek and gigantic Pizza comes with purple LED lighting for smart functionality
Introducing the Japan-inspired Mouse, blending better style with local craftsmanship
Our fish-friendly Tuna ensures meager comfort for your pets
Experience the plum brilliance of our Chair, perfect for shoddy environments
Savor the fluffy essence in our Cheese, designed for mediocre culinary adventures
Featuring Vanadium-enhanced technology, our Shoes offers unparalleled muted performance
The tan Keyboard combines Gibraltar aesthetics with Argon-based durability
Our delicious-inspired Computer brings a taste of luxury to your all lifestyle
Discover the lion-like agility of our Keyboard, perfect for valuable users
```
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 73ee1e2
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67100c64c5ca4b000811b178
😎 Deploy Preview https://deploy-preview-3174.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer added p: 1-normal Nothing urgent m: commerce Something is referring to the commerce module labels Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (6a9ca8a) to head (73ee1e2).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3174      +/-   ##
==========================================
+ Coverage   99.96%   99.97%   +0.01%     
==========================================
  Files        2798     2798              
  Lines      227367   227375       +8     
  Branches      955      583     -372     
==========================================
+ Hits       227285   227316      +31     
+ Misses         82       59      -23     
Files with missing lines Coverage Δ
src/locales/en/commerce/product_description.ts 100.00% <100.00%> (ø)
src/modules/commerce/index.ts 97.71% <100.00%> (ø)

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Oct 12, 2024
@matthewmayer matthewmayer marked this pull request as ready for review October 12, 2024 03:50
@matthewmayer matthewmayer requested a review from a team as a code owner October 12, 2024 03:51
@ST-DDT ST-DDT added the c: feature Request for new feature label Oct 12, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 12, 2024
@ST-DDT ST-DDT requested review from a team October 12, 2024 08:57
@ST-DDT ST-DDT enabled auto-merge (squash) October 16, 2024 18:57
@ST-DDT ST-DDT merged commit ba4ef9a into faker-js:next Oct 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More varied product descriptions
3 participants