-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vehicle): add more non-US vehicle manufacturers #3173
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
GitHub Actions has found some problems running the preflight checks. Please make sure to:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3173 +/- ##
=======================================
Coverage 99.96% 99.97%
=======================================
Files 2798 2798
Lines 227318 227328 +10
Branches 580 580
=======================================
+ Hits 227246 227266 +20
+ Misses 72 62 -10
|
Is this a |
I'm never sure what to pick when I'm just adding data without making any code changes. Maybe we need a new commit type for that. |
It is a locale PR. So I would love a |
But there is a difference when I add completely new locale data ( |
For the user of the new version it means, they can now use the method. Just have a look at the locale PRs and have a look at them only getting the locale tag (plus a few fix labels). |
fix #2881