Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vehicle): add more non-US vehicle manufacturers #3173

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

matthewmayer
Copy link
Contributor

fix #2881

@matthewmayer matthewmayer requested a review from a team as a code owner October 12, 2024 02:06
@matthewmayer matthewmayer added p: 1-normal Nothing urgent m: vehicle Something is referring to the vehicle module labels Oct 12, 2024
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 515f414
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/670cd0ac856c6400084c2d08
😎 Deploy Preview https://deploy-preview-3173.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

GitHub Actions has found some problems running the preflight checks.

Please make sure to:

  • run pnpm run preflight locally
  • fix all issues until the command completes without errors
  • commit and push the changes

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (9105f0a) to head (515f414).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3173   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2798     2798           
  Lines      227318   227328   +10     
  Branches      580      580           
=======================================
+ Hits       227246   227266   +20     
+ Misses         72       62   -10     
Files with missing lines Coverage Δ
src/locales/en/vehicle/manufacturer.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT added the c: locale Permutes locale definitions label Oct 12, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 12, 2024
@ST-DDT ST-DDT requested review from a team October 12, 2024 09:01
@xDivisionByZerox
Copy link
Member

Is this a refactor or a feat? I lean more towards refactor but want to hear your oppions.

@matthewmayer
Copy link
Contributor Author

I'm never sure what to pick when I'm just adding data without making any code changes. Maybe we need a new commit type for that.

@ST-DDT
Copy link
Member

ST-DDT commented Oct 13, 2024

It is a locale PR. So I would love a locale(module): nomenclature. Until then it is I'm fine with either of those.

@xDivisionByZerox
Copy link
Member

It is a locale PR. So I would love a locale(module): nomenclature. Until then it is I'm fine with either of those.

But there is a difference when I add completely new locale data (feat(locale)) or if I change (this includes additions) existing ones (refactor(locale)). 🤔

@ST-DDT
Copy link
Member

ST-DDT commented Oct 13, 2024

But there is a difference when I add completely new locale data (feat(locale)) or if I change (this includes additions) existing ones (refactor(locale)). 🤔

For the user of the new version it means, they can now use the method.
It isn't really important, whether the data were missing previously, returned bad or low variety data.
Because they either didn't use the method before (because it didn't work) or if they ran into any issues, they either reported it or at least know about the issues. And if they didn't notice any issues, then it wasn't an issue for them.

Just have a look at the locale PRs and have a look at them only getting the locale tag (plus a few fix labels).

@ST-DDT ST-DDT changed the title feat(vehicle): add more non-US vehicle manufacturers refactor(vehicle): add more non-US vehicle manufacturers Oct 14, 2024
@ST-DDT ST-DDT enabled auto-merge (squash) October 14, 2024 08:04
@ST-DDT ST-DDT merged commit 40948c3 into next Oct 14, 2024
23 checks passed
@ST-DDT ST-DDT deleted the more-vehicle-data branch October 14, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vehicle data is very US-centric
4 participants