chore(deps): remove @algolia/client-search #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
c: chore
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3157 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2778 2778
Lines 226364 226364
Branches 942 946 +4
=======================================
+ Hits 226290 226295 +5
+ Misses 74 69 -5 |
ST-DDT
approved these changes
Oct 7, 2024
import-brain
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dependency
@algolia/client-searchdoes not seem to be required. Our docs use VitePress, which is integrating Algolia out of the box. For that they use algolias DocSearch under the hood. This does not seem to require@algolia/client-search(at least from my research). Maybe it did in the previous v2, but I did not dig deeper into that.Others
Found in and extracted from #3106.