-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: verify the generated image links are working #3127
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3127 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2805 2805
Lines 217115 217115
Branches 976 979 +3
=======================================
+ Hits 217044 217048 +4
+ Misses 71 67 -4 |
The current provided solution feels like mixin unit with integration tests. IMO we should split them from each other. That way, because we rely here also on external sources, we could execute this in a scheduled workflow e.g. every week or so, so we also reduce the "ddos" outgoing from this repo. |
Team Decision
|
@xDivisionByZerox Like this or should I really use a separate folder structure? |
Thats how I do it in my projects, but I have my test files next to the actual implementation.
The structure feels natural to me. Since the tests are already in a separate directory, one might suggest splitting integration and unit tests into two directories as well:
On advantage would be that the test setup file might be more linear, since the file patter can be a diretory instead of a "crazy" pattern. Additionally, if integration tests do not have to follow the same structure like unit tests do, this might be a good approche as well. |
There are currently too many open PRs to move the unit tests to a subfolder. |
Fixes #3112
This PR adds an integration test for the image module/all methods that return a url that actually points to something to ensure the url is working as expected.
The integration tests are run once a week or on demand.