Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use defineProps deconstruction #3090

Merged
merged 4 commits into from
Sep 16, 2024
Merged

docs: use defineProps deconstruction #3090

merged 4 commits into from
Sep 16, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 5, 2024

Simplifies the vue components definitions by using deconstructors.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Sep 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 5, 2024
@ST-DDT ST-DDT requested review from a team September 5, 2024 22:46
@ST-DDT ST-DDT self-assigned this Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 2763ef9
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66e87c7ad1755900080e40f8
😎 Deploy Preview https://deploy-preview-3090.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (3e47ee7) to head (2763ef9).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3090   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2776     2776           
  Lines      226338   226338           
  Branches      589      591    +2     
=======================================
+ Hits       226267   226280   +13     
+ Misses         71       58   -13     

see 2 files with indirect coverage changes

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new syntax feels still weird to me and I would also like to explore how current state of IDE support is. Also we sadly did not benefit here in these examples of the real new feature of assigning default values and omit the use of withDefaults 🙁

@ST-DDT ST-DDT merged commit 48f171e into next Sep 16, 2024
23 checks passed
@ST-DDT ST-DDT deleted the docs/props-deconstruction branch September 16, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants